fix: Stop printing "pflag: help requested" when asked for help.#95
Merged
fix: Stop printing "pflag: help requested" when asked for help.#95
Conversation
KatrinaHoffert
approved these changes
Aug 29, 2025
Member
KatrinaHoffert
left a comment
KatrinaHoffert
left a comment
There was a problem hiding this comment.
What, you don't wanna know that help was requested?
But really, why does it do that? Have you considered seeing if they'd accept an upstream fix? Seems it's spf13/pflag#306. Which apparently has spf13/pflag#407 to fix it, but the maintainers haven't commented on it. At first I thought the repo may have been inactive, but then I noticed that there was a release just last month. So maybe worth reaching out to the maintainer to see if we can fix this upstream?
I know that's more work, so I'll approve anyway. But IMO it's the right move to take. I can't see it as intended behavior and it doesn't make sense for every pflags user to fix this themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.