Fix checklock errors discovered by #12347#12379
Open
uzairnawaz wants to merge 1 commit intogoogle:masterfrom
Open
Fix checklock errors discovered by #12347#12379uzairnawaz wants to merge 1 commit intogoogle:masterfrom
uzairnawaz wants to merge 1 commit intogoogle:masterfrom
Conversation
ayushr2
approved these changes
Dec 14, 2025
uzairnawaz
force-pushed
the
fix-new-checklock-errors
branch
from
74be08b to
13541de
Compare
…ttached fix new checklock errors revert pass on prev and new checklocks versions remove whitespace
uzairnawaz
force-pushed
the
fix-new-checklock-errors
branch
from
13541de to
9871b5a
Compare
tamird
reviewed
Jan 7, 2026
| // Finally just give up and wait for the Lock. | ||
| e.mu.Lock() | ||
| e.ownedByUser.Store(1) | ||
| return // +checklocksforce: this locks e.snd.ep.mu |
Contributor
There was a problem hiding this comment.
what's going on here? why is a bare return at the end of a function needed?
here and all others
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in #12347 led to additional errors being reported in existing code. This PR addresses those issues with additional annotations.