Add support for (optional) population of packet type in afpacket via ancillary data#1168
Open
hmahmood wants to merge 1 commit intogoogle:masterfrom
Open
Add support for (optional) population of packet type in afpacket via ancillary data#1168hmahmood wants to merge 1 commit intogoogle:masterfrom
hmahmood wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@florianl could you please review this since you reviewed the original PR? Thanks |
florianl
approved these changes
Jun 14, 2024
Contributor
florianl
left a comment
florianl
left a comment
There was a problem hiding this comment.
looks good to me 👍
As I'm not a maintainer of this codebase, I'm not sure about the relavance of my feedback.
…ancillary data (#1)
hmahmood
force-pushed
the
hasan.mahmood/afpacket-pkttype
branch
from
79b4b7d to
4ac4cee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviving #1051