fix!: Replace UserListOptions.ListOptions with UserListOptions.PerPage#3977
Merged
gmlewis merged 4 commits intogoogle:masterfrom Feb 8, 2026
Merged
fix!: Replace UserListOptions.ListOptions with UserListOptions.PerPage#3977gmlewis merged 4 commits intogoogle:masterfrom
UserListOptions.ListOptions with UserListOptions.PerPage#3977gmlewis merged 4 commits intogoogle:masterfrom
Conversation
alexandear
reviewed
Feb 8, 2026
alexandear
reviewed
Feb 8, 2026
Contributor
|
Updates #3976 |
alexandear
approved these changes
Feb 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3977 +/- ##
==========================================
- Coverage 93.53% 93.52% -0.01%
==========================================
Files 207 207
Lines 17586 17569 -17
==========================================
- Hits 16449 16432 -17
Misses 937 937
Partials 200 200 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
approved these changes
Feb 8, 2026
Collaborator
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra and @alexandear!
LGTM.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Replaced
UserListOptions.ListOptionswithUserListOptions.PerPagewhich will also result in removal ofUsersService.ListAllIterUsersService.ListAll don't have
pageacc to docs if you run ListAllIter it will go in infinite loop since its pagination is powered exclusively by the since parameter.Related: #3976