Skip to content

docs: Clarify nil http.Client usage has no timeout #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gmlewis merged 2 commits into from
Jan 12, 2026
+4 −0
Merged

docs: Clarify nil http.Client usage has no timeout #3910

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
179669a
doc: Add security warning to NewClient
google-labs-jules[bot] Jan 11, 2026
7409d8e
Merge pull request #1 from merchantmoh-debug/bolt-sentinel-client-imp…
merchantmoh-debug Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions github/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,10 @@ func addOptions(s string, opts any) (string, error) {
// authentication, either use Client.WithAuthToken or provide NewClient with
// an http.Client that will perform the authentication for you (such as that
// provided by the golang.org/x/oauth2 library).
//
// Note: When using a nil httpClient, the default client has no timeout set.
// This may not be suitable for production environments. It is recommended to
// provide a custom http.Client with an appropriate timeout.
func NewClient(httpClient *http.Client) *Client {
if httpClient == nil {
httpClient = &http.Client{}
Expand Down
Loading