Strengthen parser required-field and FlexBuffers JSON null test oracles#9080
Open
parasol-aser wants to merge 1 commit intogoogle:masterfrom
Open
Strengthen parser required-field and FlexBuffers JSON null test oracles#9080parasol-aser wants to merge 1 commit intogoogle:masterfrom
parasol-aser wants to merge 1 commit intogoogle:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestError()cases inErrorTest()pinning parser diagnostics forrequiredannotations:requiredon scalar table fields,requiredon struct fields, and missing required scalar/table fields during JSON parse.ParseFlexbuffersFromJsonWithNullTest()so each int / double / null case assertsParser::ParseFlexBuffer(...) == trueandflexbuffers::VerifyBuffer(...) == truebefore reading values. Previously the return value ofParseFlexBufferwas silently dropped, so a parser regression would only surface as UB in the downstreamAsInt64()/AsDouble()/IsNull()reads.Coverage
Targeted lcov before/after on
flattestsshowssrc/idl_parser.cppgaining 4 newly-hit lines (1155,1164,1627,1628) — theError()call sites for the new diagnostics.Validation
Passes. Diff is test-only; no production changes.
Risk
Low. The parser-error assertions match diagnostic substrings, so they would need an update if those messages are ever reworded — consistent with the ~50 existing
TestError()cases in this file.