Fix LeakSanitizer leak in CrossNamespacePackTest#9079
Open
parasol-aser wants to merge 1 commit intogoogle:masterfrom
Open
Fix LeakSanitizer leak in CrossNamespacePackTest#9079parasol-aser wants to merge 1 commit intogoogle:masterfrom
parasol-aser wants to merge 1 commit intogoogle:masterfrom
Conversation
Consumer::UnPack() returns an owning raw pointer (the generated code does `_o.release()`), so the caller must take ownership. The test added in google#8948 stored the result in `auto`, leaking the ConsumerT and its nested allocations -- LSan reports 48 bytes in 4 allocations. Wrap in std::unique_ptr, matching the pattern already used for the other UnPack() call site at tests/test.cpp:298 (which deletes explicitly).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consumer::UnPack()returns an owning raw pointer;CrossNamespacePackTest(added in [C++] Tables containing native tables from a different namespace missing namespace in Pack function #8948) dropped it on the floor, leaking the unpacked object and its nested allocations.flattestsunder ASan/LSan reports48 byte(s) leaked in 4 allocation(s)with the top frame attests/test.cpp:1742.std::unique_ptr, matching the existing pattern attests/test.cpp:298(which usesdelete movie_object;).Reproduction
Before:
0% tests passed(LSan failure, 48 bytes / 4 allocations).After:
100% tests passed.