Skip to content

Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mirkoalicastro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #5553 : Skip UnnecessaryOptionalGet when lambda parameter is unnamed #5649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/com/google/errorprone/bugpatterns/UnnecessaryOptionalGet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
return Description.NO_MATCH;
}
VariableTree arg = getOnlyElement(lambdaExpressionTree.getParameters());
if ("_".equals(state.getSourceForNode(arg))) {
return Description.NO_MATCH;
}
SuggestedFix.Builder fix = SuggestedFix.builder();
new TreeScanner<Void, VisitorState>() {
@Override
Expand Down
22 changes: 22 additions & 0 deletions core/src/test/java/com/google/errorprone/bugpatterns/UnnecessaryOptionalGetTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

package com.google.errorprone.bugpatterns;

import static com.google.common.truth.TruthJUnit.assume;

import com.google.errorprone.BugCheckerRefactoringTestHelper;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -388,4 +390,24 @@ private void home() {
""")
.doTest();
}

@Test
public void unnamedVariable_doesNotSuggestFix() {
assume().that(Runtime.version().feature()).isAtLeast(22);
refactoringTestHelper
.addInputLines(
"Test.java",
"""
import java.util.Optional;

public class Test {
private void home() {
Optional<String> op = Optional.of("hello");
op.ifPresent(_ -> System.out.println(op.get()));
}
}
""")
.expectUnchanged()
.doTest();
}
}