Skip to content

Remove the RedundantSetterCall:Improvements flag. #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Feb 6, 2026
+1 −10
Merged

Remove the RedundantSetterCall:Improvements flag. #5491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions core/src/main/java/com/google/errorprone/bugpatterns/RedundantSetterCall.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
import com.google.common.collect.ListMultimap;
import com.google.errorprone.BugPattern;
import com.google.errorprone.BugPattern.StandardTags;
import com.google.errorprone.ErrorProneFlags;
import com.google.errorprone.VisitorState;
import com.google.errorprone.bugpatterns.BugChecker.MethodInvocationTreeMatcher;
import com.google.errorprone.fixes.SuggestedFix;
Expand All @@ -63,7 +62,6 @@
import java.util.Collection;
import java.util.Map;
import java.util.regex.Pattern;
import javax.inject.Inject;
import org.jspecify.annotations.Nullable;

/** A BugPattern; see the summary. */
Expand Down Expand Up @@ -108,13 +106,6 @@ && isWithinAutoValueBuilder(symbol, state)
(ExpressionTree) state.getPath().getParentPath().getParentPath().getLeaf(),
state)));

private final boolean improvements;

@Inject
RedundantSetterCall(ErrorProneFlags flags) {
this.improvements = flags.getBoolean("RedundantSetterCall:Improvements").orElse(true);
}

@Override
public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) {
if (!TERMINAL_FLUENT_SETTER.matches(tree, state)) {
Expand Down Expand Up @@ -147,7 +138,7 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
if (methodName.endsWith("Builder")) {
break;
}
if (improvements && isProto && methodName.startsWith("set")) {
if (isProto && methodName.startsWith("set")) {
String withoutSet = methodName.replaceFirst("^set", "");
if (!fieldNames.contains(toUpperCase(withoutSet))) {
if (methodName.endsWith("Value")) {
Expand Down
Loading