Update Dagger to be stricter about wildcard types.#5151
Merged
copybara-service[bot] merged 1 commit intomasterfrom Apr 9, 2026
Merged
Update Dagger to be stricter about wildcard types.#5151copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
The change in aosp/4011581 will be a breaking change for Dagger because type arguments will no longer implement `XType`, instead they will implement `XTypeArgument` which contains both a `XVariance` and an `XType`. This means that wildcard types need to be handled explicitly. This CL adds checks to Dagger's codebase that will make migrating to the new API easier. In particular, this CL adds `XTypes.checkInvariantType` and `XTypes.getInvariantType()` that wrap type arguments to make it explicit whether we require the type argument to be invariant or whether the variance just isn't important and we can ignore it. The plan for migration will be: 1. submit this CL 2. submit aosp/4011581 3. submit CL/892735159 RELNOTES=N/A PiperOrigin-RevId: 897352928
copybara-service
bot
force-pushed
the
test_894284536
branch
from
7681fd5 to
6113471
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Dagger to be stricter about wildcard types.
The change in aosp/4011581 will be a breaking change for Dagger because type arguments will no longer implement
XType, instead they will implementXTypeArgumentwhich contains both aXVarianceand anXType. This means that wildcard types need to be handled explicitly.This CL adds checks to Dagger's codebase that will make migrating to the new API easier. In particular, this CL adds
XTypes.checkInvariantTypeandXTypes.getInvariantType()that wrap type arguments to make it explicit whether we require the type argument to be invariant or whether the variance just isn't important and we can ignore it.The plan for migration will be:
RELNOTES=N/A