Skip to content

Upgrade kotlin and ksp dependencies. #5062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade kotlin and ksp dependencies. #5062

copybara-service wants to merge 1 commit into from
+61 −129

Conversation

@copybara-service
Copy link

@copybara-service copybara-service bot commented Dec 17, 2025

Upgrade kotlin and ksp dependencies.

Fixes #5001
Fixes #5059

RELNOTES=Fixes #5001, #5059: Upgrade kotlin and ksp dependencies.

philips77
philips77 reviewed Dec 18, 2025
View reviewed changes
gradle/libs.versions.toml
kotlin = "2.3.0"
kotlinTarget = "1.9"
ksp = "2.2.20-2.0.3"
ksp = "2.4.3"
Copy link

@philips77 philips77 Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 2.3.4?
https://github.com/google/ksp/releases

@ychescale9 ychescale9 mentioned this pull request Dec 18, 2025
Open
JWvanVPostNL
JWvanVPostNL reviewed Dec 19, 2025
View reviewed changes
gradle/libs.versions.toml
kotlin = "2.3.0"
kotlinTarget = "1.9"
ksp = "2.2.20-2.0.3"
ksp = "2.4.3"
Copy link

@JWvanVPostNL JWvanVPostNL Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ksp = "2.4.3"
ksp = "2.3.4"

@bcorso
Upgrade kotlin and ksp dependencies.
0a770ff 
Fixes #5001
Fixes #5059

RELNOTES=Fixes #5001, #5059: Upgrade kotlin and ksp dependencies.
PiperOrigin-RevId: 845858016
@Mgtantheta
Copy link

Mgtantheta commented Dec 25, 2025

Hi team,

We're currently blocked on upgrading to Kotlin 2.3.0 due to this
kotlin-metadata-jvm compatibility issue.

As other reviewers mentioned, the KSP version should be 2.3.4
(not 2.4.3) to match Kotlin 2.3.0.

Is there a timeline for merging this fix and releasing a new version?

Thanks for your work on Dagger/Hilt!

@bcorso
Copy link

bcorso commented Dec 26, 2025

We're currently blocked on upgrading to Kotlin 2.3.0 due to this
kotlin-metadata-jvm compatibility issue.

You should not be blocked by this. See the comments in #5001 for the workaround.

As other reviewers mentioned, the KSP version should be 2.3.4
(not 2.4.3) to match Kotlin 2.3.0.

The KSP version (while incorrect) is not the reason this PR has not been merged. As mentioned in #5001 (comment), we're waiting on our testing infra to upgrade to Kotlin 2.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@philips77 philips77 philips77 left review comments

@JWvanVPostNL JWvanVPostNL JWvanVPostNL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade kotlin-metadata-jvm to support Kotlin 2.3.0 Support kotlin-metadata-jvm library 2.3.0

4 participants

@Mgtantheta @bcorso @philips77 @JWvanVPostNL