Render ANSI color codes in playground stderr output#2651
Closed
08volt wants to merge 1 commit intogoogle:mainfrom
Closed
Render ANSI color codes in playground stderr output#265108volt wants to merge 1 commit intogoogle:mainfrom
08volt wants to merge 1 commit intogoogle:mainfrom
Conversation
djmitche
reviewed
Feb 20, 2025
Collaborator
djmitche
left a comment
There was a problem hiding this comment.
This is fantastic!
Is there some other trick required to get the stderr to contain the ANSI escapes? I tried running this with mdbook serve and I still see plain-text errors.
Author
Hi @djmitche I wanted to try with rust-lang/rust-playground@ff5903e but I was stuck trying to run the rust-playground locally |
Collaborator
|
Hm, I haven't run the playground locally, either. Would it be easier to just propose and get that change merged upstream instead? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a function
styleStderrOutputthat parses ANSI color codes from the Rust compiler's stderr output and converts them into inline HTML<span>elements with corresponding CSS styles. This allows the embedded playground to display colored compiler error messages, improving the user experience and more accurately reflecting the Rust compiler's output.Motivation
Implementation Details
styleStderrOutputfunction uses a regular expression to split the stderr output into text and ANSI color code sequences.<span>elements with inline styles.Related Issues