Open
Conversation
This comment was marked as spam.
This comment was marked as spam.
jardondiego
commented
Mar 6, 2026
| headers = { | ||
| 'Accept': 'application/json', | ||
| 'Content-Type': 'application/json', | ||
| 'Authorization': creds.token |
Collaborator
Author
There was a problem hiding this comment.
AFAIU, 'Authorization' header should be formatted as proposed in this PR.
jardondiego
commented
Mar 6, 2026
Comment on lines
+155
to
+156
| if not creds.valid: | ||
| creds.refresh(requests.Request()) |
Collaborator
Author
There was a problem hiding this comment.
When credentials expire, refresh them.
This comment was marked as spam.
This comment was marked as spam.
jardondiego
commented
Mar 7, 2026
| @@ -151,10 +152,13 @@ def push_swarming_task(command, download_url, job_type): | |||
|
|
|||
| task_spec = _get_new_task_spec(command, job_type, download_url) | |||
| creds, _ = credentials.get_default() | |||
Collaborator
Author
There was a problem hiding this comment.
We should validate the this uses the same service account which has permissions to trigger Swarming tasks.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.