-
Notifications
You must be signed in to change notification settings - Fork 611
Add old state and diff logging on fuzzer update #5184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8f29591
Add old state and diff logging on fuzzer update
tbantikyan b8db751
Merge branch 'master' into fuzzer-update-logging
tbantikyan cc13b6b
Merge branch 'master' into fuzzer-update-logging
tbantikyan a1ebe13
Use ndb to_dict method to get Fuzzer fields.
tbantikyan 8b2446c
Annotate methods and simplify dict to string logic
tbantikyan 7e764b1
Update empty diff output to empty string
tbantikyan 14f755c
Fix type syntax issue and add new line for output
tbantikyan 42dd50f
Merge branch 'master' into fuzzer-update-logging
tbantikyan a73fc33
Add unit testing
tbantikyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 changes: 58 additions & 0 deletions
58
src/clusterfuzz/_internal/tests/appengine/handlers/fuzzers_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| """Tests for fuzzers handler.""" | ||
| # pylint: disable=protected-access | ||
|
|
||
| import datetime | ||
| import unittest | ||
|
|
||
| from clusterfuzz._internal.datastore import data_types | ||
| from handlers import fuzzers | ||
|
|
||
|
|
||
| class BaseEditHandlerTest(unittest.TestCase): | ||
| """Test BaseEditHandler.""" | ||
|
|
||
| def setUp(self): | ||
| self.handler = fuzzers.BaseEditHandler() | ||
|
|
||
| def test_get_fuzzer_state_str(self): | ||
| """Test that fuzzer state str excludes specific fields.""" | ||
| fuzzer = data_types.Fuzzer( | ||
| name='test_fuzzer', | ||
| revision=1, | ||
| timeout=10, | ||
| result='bad', | ||
| console_output='some output', | ||
| result_timestamp=datetime.datetime(2021, 1, 1), | ||
| return_code=1, | ||
| sample_testcase='testcase', | ||
| stats_columns='cols', | ||
| stats_column_descriptions='desc', | ||
| ) | ||
|
|
||
| state_str = self.handler._get_fuzzer_state_str(fuzzer) | ||
|
|
||
| self.assertIn('name: test_fuzzer', state_str) | ||
| self.assertIn('revision: 1', state_str) | ||
| self.assertIn('timeout: 10', state_str) | ||
|
|
||
| # Explicitly excluded fields | ||
| self.assertNotIn('result:', state_str) | ||
| self.assertNotIn('result_timestamp', state_str) | ||
| self.assertNotIn('console_output:', state_str) | ||
| self.assertNotIn('return_code:', state_str) | ||
| self.assertNotIn('sample_testcase:', state_str) | ||
| self.assertNotIn('stats_columns:', state_str) | ||
| self.assertNotIn('stats_column_descriptions:', state_str) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.