-
Notifications
You must be signed in to change notification settings - Fork 596
Fix unknown ubsan crash types #5133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Can you do a query and check if there are others? |
Sure, here it is (probably not the best way to do it, but it confirms there aren't others): https://cloudlogging.app.goo.gl/Ff7E3wkP3VnrGdt17 |
jonathanmetzman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Actually, just found another one: |
|
Also, I think the AFAICT all projects reporting these as unknown crash types are go project (jobs: |
|
PTAL. I added the real two new types as non security issues, please let me know if you think otherwise. |
jonathanmetzman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| state.crash_state = '' | ||
| state.frame_count = 0 | ||
| continue | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope this doesn't break anything.
|
Thanks! |
| new_type='Bad-cast', | ||
| new_frame_count=0) | ||
|
|
||
| # Golang stacktraces. Needs to be done before the other UBSan crash as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually. I'm not sure what's the right thing to do here.
This should fix the following unknown ubsan crash types (https://screenshot.googleplex.com/C4sGA6UKssV4Gms.png):
assumption is violated during executionupcast of null pointer of type <type>These two are actually related to golang specific crashes:
slice bounds out of range [:-1]index out of range [-1]It should be fixed by checking the golanc specific crash types before the generic UBSan, since if it is a golang crash, it will set the
crash_typeand it will not enter the generic UBSan block.Added unit test for the new ubsan types.
b/473559705