Update Component ID Logic #5074
Conversation
|
/gcbrun |
|
|
||
| recovered_exception = None | ||
| try: | ||
| if issue_tracker.project == "google-buganizer": |
There was a problem hiding this comment.
@jonathanmetzman Do you see any issues with adding logs with this kind of data?
There was a problem hiding this comment.
I think the TL;DR here is some of our fuzzers are finding bugs and trying to assign them to buganizer components where ClusterFuzz does not have access. So, it silently fails to create bugs in the component's where developers are expecting them.
There was a problem hiding this comment.
@javanlacerda Please take a look when you have a moment
There was a problem hiding this comment.
What do you think the logging issue would be?
There was a problem hiding this comment.
@jonathanmetzman I think when I commented on this initially, I was concerned that ClusterFuzz instances will be logging potentially sensitive data in the form of buganizer components.
Upon further thought, only the owners of the instance will have access to these logs. So no, I don't think there is any issue with this, and it will help us to better assign issues to owners in our instance.
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
from
479ef6c to
5b68ab1
Compare
|
/gcbrun |
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
from
5b68ab1 to
1253c06
Compare
|
/gcbrun |
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
2 times, most recently
from
4f13515 to
e75acf8
Compare
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
from
e75acf8 to
619b4b0
Compare
|
/gcbrun |
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
3 times, most recently
from
2be632c to
78e1722
Compare
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
from
78e1722 to
b595f85
Compare
Some issues are not getting filed into the desired component of their code owners. This component is provided as a metadata. The current change aims at emphasising this metadata component by removing the automatic component. Please refer to b/438511288 for additional details.
AashutoshMurthy
force-pushed
the
update_component_id_logic
branch
from
b595f85 to
1eebbc4
Compare
|
/gcbrun |
| if issue_tracker.project != "google-buganizer" and \ | ||
| testcase.one_time_crasher_flag and \ | ||
| policy.unreproducible_component: |
There was a problem hiding this comment.
Can you use parenthesis here?
| # Clear the automatic component to prioritize the metadata component. | ||
| logs.info( | ||
| "Removed the automatic component to emphasize the metadata component.") | ||
| issue.components.clear() |
There was a problem hiding this comment.
I don't think so because google-buganizer is only used by android/g3.
|
|
||
| metadata_components = _get_from_metadata(testcase, 'issue_components') | ||
|
|
||
| if issue_tracker.project == "google-buganizer" and metadata_components: |
There was a problem hiding this comment.
single quotes please
| # Clear the automatic component to prioritize the metadata component. | ||
| logs.info( | ||
| "Removed the automatic component to emphasize the metadata component.") | ||
| issue.components.clear() |
There was a problem hiding this comment.
I don't think so because google-buganizer is only used by android/g3.
5 participants
Some issues are not getting filed into the desired component of their code owners. This component is provided as a metadata.
The current change aims at emphasising this metadata component by removing the automatic component.
Please refer to b/438511288 for additional details.