Skip to content

Added exponential backoff to snapshot creation throttling errors #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramo-j wants to merge 1 commit into from
Closed

Added exponential backoff to snapshot creation throttling errors #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion libcloudforensics/providers/gcp/forensics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import random
import re
import subprocess
import time
from typing import List, Tuple, Optional, Dict, Any, Union, Sequence

from google.auth.exceptions import DefaultCredentialsError
Expand Down Expand Up @@ -90,7 +91,22 @@ def CreateDiskCopy(
disk_type = 'pd-standard'

logger.info('Disk copy of {0:s} started...'.format(disk_to_copy.name))
snapshot, created = disk_to_copy.Snapshot()

attempts = 0
max_attempts = 5
backoff = 1
while attempts < max_attempts:
try:
attempts += 1
snapshot, created = disk_to_copy.Snapshot()
break
except RuntimeError as exception:
if 'RESOURCE_OPERATION_RATE_EXCEEDED' not in str(exception) or attempts >= max_attempts:
raise exception
logger.debug('Snapshot creation throttled: Pausing {0:d} seconds'.format(backoff))
time.sleep(backoff)
backoff ** 2

logger.debug('Snapshot created: {0:s}'.format(snapshot.name))
new_disk = dst_project.compute.CreateDiskFromSnapshot(
snapshot, disk_name_prefix='evidence', disk_type=disk_type)
Expand Down
Loading