Skip to content

Avoid std::invoke and just directly call visitors to avoid ugly frames in pprof #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 21, 2025
Merged

Avoid std::invoke and just directly call visitors to avoid ugly frames in pprof #1365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions common/internal/byte_string.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,14 @@ ByteString final {
void HashValue(absl::HashState state) const;

template <typename Visitor>
std::common_type_t<std::invoke_result_t<Visitor, absl::string_view>,
std::invoke_result_t<Visitor, const absl::Cord&>>
Visit(Visitor&& visitor) const {
decltype(auto) Visit(Visitor&& visitor) const {
switch (GetKind()) {
case ByteStringKind::kSmall:
return std::invoke(std::forward<Visitor>(visitor), GetSmall());
return std::forward<Visitor>(visitor)(GetSmall());
case ByteStringKind::kMedium:
return std::invoke(std::forward<Visitor>(visitor), GetMedium());
return std::forward<Visitor>(visitor)(GetMedium());
case ByteStringKind::kLarge:
return std::invoke(std::forward<Visitor>(visitor), GetLarge());
return std::forward<Visitor>(visitor)(GetLarge());
}
}

Expand Down Expand Up @@ -664,15 +662,13 @@ class ABSL_ATTRIBUTE_TRIVIAL_ABI ByteStringView final {
void HashValue(absl::HashState state) const;

template <typename Visitor>
std::common_type_t<std::invoke_result_t<Visitor, absl::string_view>,
std::invoke_result_t<Visitor, const absl::Cord&>>
Visit(Visitor&& visitor) const {
decltype(auto) Visit(Visitor&& visitor) const {
switch (GetKind()) {
case ByteStringViewKind::kString:
return std::invoke(std::forward<Visitor>(visitor), GetString());
return std::forward<Visitor>(visitor)(GetString());
case ByteStringViewKind::kCord:
return std::invoke(std::forward<Visitor>(visitor),
static_cast<const absl::Cord&>(GetSubcord()));
return std::forward<Visitor>(visitor)(
static_cast<const absl::Cord&>(GetSubcord()));
}
}

Expand Down