[containerd-cri]Set HasFilesystem to true

[vasireddy99]

This PR sets the hasFilesystem to true in containerd-cri branch to collect ContainerFS metrics.

Referring to this comment looks like containerd-cri would be the right branch to use for collecting disk usage metrics with contianerd as the runtime. but filesytem metrics didn't comethrough and found out that setting is set to false and modifying it to true has worked.

Replicated it in local and following is the result:

    "Timestamp": "1677108918008",
    "Type": "ContainerFS",
    "Version": "0",
    "container_filesystem_available": 0,
    "container_filesystem_capacity": 85886742528,
    "container_filesystem_usage": 3396182016,
    "container_filesystem_utilization": 3.954256403300903,
    "device": "/dev/nvme0n1p1",
    "fstype": "vfs",
    "kubernetes": {
        "container_name": "coredns",
        "containerd": {
            "container_id": "*****0358cd9e3ee41c0975394**********"
        },

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[k8s-ci-robot]

Hi @vasireddy99. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rapphil]

@bobbypage can you take a look into this pr?

[sky333999]

@bobbypage following up to see if you've had the chance to look at this yet?

We are also looking for filesystem metrics and blocked on this change.

[iwankgb]

Sorry for the delay, let's see what tests say.

[sidewinder12s]

@vasireddy99 What did you guys see without this set? Were the metrics still there but just incorrect?

[iwankgb]

@vasireddy99 - could you merge master to the branch, please?

[vasireddy99]

@vasireddy99 - could you merge master to the branch, please?

oh actually, master branch is diverged from the containerd-cri branch, So i wont be able merge it to the master

[iwankgb]

@vasireddy99, I don't think we can proceed without bringing containerd-cri up-to-date 😿

[chengjoey]

#3502

[chengjoey]

Just setting hasFilesystem to true is not enough, because looking at the code, there is no fsHandler to handle containerd