feat: strictly block legacy agent instantiation under controller V2 build tag#47
Draft
anj-s wants to merge 1 commit into
Draft
feat: strictly block legacy agent instantiation under controller V2 build tag#47anj-s wants to merge 1 commit into
anj-s wants to merge 1 commit into
Conversation
anj-s
force-pushed
the
u/anj/harness-registry
branch
from
1e468eb to
7ca09e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
harnessbuild tag) controller.NewControllerFromConfigloader (cliutil_harness.go) to ensure the V2 registry can detect and throw custom validation errors when legacy agent IDs are requested.registry_test.goandcontroller_test.goasserting the correct and precise blockade behavior.Type of Change
Related Issues
Closes #323
Test Plan
go test -tags harness ./...andgo test ./...all pass cleanly with 100% success)ax exec --agent coding-agent --input "hello"on aharnessbuild tag compiled binary, and verified it cleanly fails fast withagent "coding-agent" is registered under legacy agent config but has no V2 harness interface implementation.