Skip to content

Ignore unexpected warnings in PerfDataSampleReader::Append #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zcfh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ignore unexpected warnings in PerfDataSampleReader::Append #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sample_reader.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,13 @@ bool PerfDataSampleReader::Append(const std::string &profile_file) {
continue;
}

// if from_ip map in perf_data_converter PerfParser::MapBranchStack fails but to_ip map succeeeds.
// Then from.offset() == 0 and to.offset() == ${offset}.
// This will cause the following check to erroneously warning "Bogus LBR data".
if (event.branch_stack[i - 1].from.dso_info_ == NULL) {
continue;
}

// TODO(b/62827958): Get rid of this temporary workaround once the issue
// of duplicate entries in LBR is resolved. It only happens at the head
// of the LBR. In addition, it is possible that the duplication is
Expand All @@ -333,7 +340,8 @@ bool PerfDataSampleReader::Append(const std::string &profile_file) {
(event.branch_stack[0].from.offset() -
event.branch_stack[0].to.offset() >
absl::GetFlag(FLAGS_strip_dup_backedge_stride_limit))) {
LOG(WARNING) << "Bogus LBR data (duplicated top entry)";
if (event.branch_stack[1].from.dso_info_ == NULL)
LOG(WARNING) << "Bogus LBR data (duplicated top entry)";
continue;
}
uint64_t begin = event.branch_stack[i].to.offset();
Expand Down