Enforce misc-include-cleaner on assemble_cvd/android_build

base/cvd/BUILD.bazel

@@ -24,6 +24,7 @@ filegroup(
     name = "clang_tidy_config",
     srcs = [
         ".clang-tidy",
+        "//cuttlefish/host/commands/assemble_cvd/android_build:.clang-tidy",
         "//cuttlefish/host/commands/cvd/cli/commands:.clang-tidy",
         "//cuttlefish/host/commands/kernel_log_monitor:.clang-tidy",
         "//cuttlefish/host/commands/mkenvimage_slim:.clang-tidy",

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/.clang-tidy

@@ -0,0 +1,29 @@
+# "clang-diagnostic-pragma-once-outside-header" has a bad interaction with the
+# `parse_headers` bazel feature.
+
+Checks: &checks >-
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  -clang-diagnostic-pragma-once-outside-header,
+  misc-definitions-in-headers,
+  misc-include-cleaner,
+  misc-unused-alias-decls,
+  readability-avoid-const-params-in-decls,
+  readability-const-return-type,
+  readability-container-size-empty,
+  readability-inconsistent-declaration-parameter-name,
+  readability-misleading-indentation,
+  readability-redundant-control-flow,
+  readability-string-compare,
+
+# Using the bazel clang-tidy helper, warnings are not shown from files that
+# don't have any errors.  "*" here treats everything from `Checks` as an error,
+# and from there some exclusions are added.
+WarningsAsErrors: >
+  *,
+  -clang-analyzer-core.uninitialized.Assign,
+  -clang-analyzer-core.UndefinedBinaryOperatorResult,
+  -clang-diagnostic-builtin-macro-redefined,
+  -clang-diagnostic-pragma-once-outside-header,
+  -clang-diagnostic-unused-const-variable,
+  -clang-diagnostic-unused-variable,

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/android_builds.cc

@@ -17,6 +17,7 @@
 
 #include <stddef.h>
 
+#include <map>
 #include <memory>
 #include <ostream>
 #include <utility>

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/android_dist_build.cc

@@ -17,6 +17,7 @@
 
 #include <memory>
 #include <string>
+#include <string_view>
 #include <utility>
 #include <vector>
 

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/identify_build.cc

@@ -16,6 +16,7 @@
 #include "cuttlefish/host/commands/assemble_cvd/android_build/identify_build.h"
 
 #include <memory>
+#include <ostream>
 #include <string>
 #include <utility>
 #include <vector>

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/physical_partitions.cc

@@ -19,6 +19,7 @@
 #include <memory>
 #include <ostream>
 #include <set>
+#include <string>
 
 #include "cuttlefish/host/commands/assemble_cvd/android_build/android_build.h"
 #include "cuttlefish/result/result.h"

base/cvd/cuttlefish/host/commands/assemble_cvd/android_build/super_image.cc

@@ -15,10 +15,13 @@
 
 #include "cuttlefish/host/commands/assemble_cvd/android_build/super_image.h"
 
+#include <fcntl.h>
 #include <stdint.h>
+#include <stdio.h>
 #include <unistd.h>
 
 #include <functional>
+#include <map>
 #include <memory>
 #include <ostream>
 #include <set>