Add data_policy to list of flags gathered for metrics
#2065
+135
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To re-use the same parsing logic for metrics gathering. Bug:442664611
Not yet converted for transmission, but available. Bug: 442664611
Bug: 442664611
cjreynol
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
approved these changes
Jan 27, 2026
| Result<DataPolicyFlag> DataPolicyFlag::FromGlobalGflags() { | ||
| const auto flag_info = gflags::GetCommandLineFlagInfoOrDie(kFlagName); | ||
| std::vector<std::string> flag_values = | ||
| CF_EXPECT(StringFromGlobalGflags(flag_info, kFlagName)); |
Member
There was a problem hiding this comment.
Can we take this opportunity to move the string-to-enum conversion earlier, so we can do an enum-to-enum conversion in the metrics code instead?
The other conversion only happens when reading from the config so the ideal would be to store the enum in the config, but that expands the scope of this change by a bit.
| using logs::proto::wireless::android::cuttlefish::events::MetricsEventV2; | ||
|
|
||
| CuttlefishFlags_DataPolicy ConvertDataPolicy(std::string_view data_policy) { | ||
| if (data_policy == "always_create") { |
Member
There was a problem hiding this comment.
Can these use the common string constants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I saw there is a 4th value listed in the help text for
data_policy, but there is no matching enum value. Reference:android-cuttlefish/base/cvd/external_proto/cf_flags.proto
Line 67 in 7f77e3f
Bug: 442664611