-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: record usage metadata on compaction events #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: record usage metadata on compaction events #4026
Conversation
Summary of ChangesHello @https-sam, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a gap in session analytics by ensuring that token usage from LLM calls made during event compaction is no longer lost. By capturing and attaching Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds tracking for token usage during compaction events by capturing usage_metadata and attaching it to the resulting Event. The implementation is straightforward and includes a new unit test to verify the functionality. I've included one suggestion to make the logic for capturing the metadata more robust against potential edge cases.
…adata in the same if branch Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
Compaction runs a separate LLM call to summarize events, but the resulting
compaction event did not carry
usage_metadata, so token usage for compactionwas lost in session analytics.
Solution:
Capture the summarizer LLM response
usage_metadataand attach it to thecompaction
Eventso it is persisted and queryable like other LLM usage.Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
N/A
Checklist
Additional context
As a potential enhancement, we could tag compaction events in
custom_metadatalikeusage_kind=compactionso analytics can easily include/exclude summarization cost without inspectingactions.compaction.