-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Add editLimit parameter to GraphQL query #3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ryanaiagent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Response from ADK Triaging Agent Hello @ryanaiagent, thank you for creating this PR! This PR is a bug fix, could you please associate a GitHub issue with this PR? If there is no existing issue, could you please create one? In addition, could you please provide a testing plan in the PR description? This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a GraphQL error by adding the missing $editLimit variable to the query signature. The change is accurate and resolves the described bug. I have added one suggestion to improve the readability of the GraphQL query by formatting the parameters across multiple lines, which can be helpful as more parameters are added in the future.
|
@xuanyang15 , the stale agent ran successfully. However due to a small missing parameter inside the query it wasn't fetching the issue correctly. Updated it now. Can we get this merged. |
|
Thank you @ryanaiagent for your contribution! 🎉 Your changes have been successfully imported and merged via Copybara in commit 76dc169. Closing this PR as the changes are now in the main branch. |
🚨 UPDATE: Bug Fix for GraphQL Error
A bug was discovered during a workflow run where the agent was failing with the error:
GraphQL Error: Variable $editLimit is used by anonymous query but not declared.This was caused by a missing variable declaration in the GraphQL query signature. The fix adds the required declaration, resolving the error.
Change in
agent.py: