-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix typo several files #3365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo several files #3365
Conversation
Summary of ChangesHello @UlookEE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the overall quality and readability of the codebase by addressing and correcting several typographical errors found in various Python files. These minor adjustments, primarily within docstrings and comments, ensure that the documentation and inline explanations are accurate and professional. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes several typos and grammatical errors across various files, primarily in docstrings. The changes are correct and improve the clarity of the documentation. I've added a few suggestions to further improve code style by shortening some long lines in docstrings to adhere to PEP 8 recommendations, enhancing readability.
|
@UlookEE could you help add a line of "from future import annotations" to src/google/adk/sessions/state.py? https://github.com/google/adk-python/actions/runs/19044530131/job/54389399460?pr=3365 |
|
@wuliang229 completed |
Merge #3365 **Please ensure you have read the [contribution guide](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) before creating a pull request.** fix typo for several files. ### Checklist - [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document. - [x] I have performed a self-review of my own code. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have added tests that prove my fix is effective or that my feature works. - [x] New and existing unit tests pass locally with my changes. - [x] I have manually tested my changes end-to-end. - [x] Any dependent changes have been merged and published in downstream modules. ### Additional context _Add any other context or screenshots about the feature request here._ Co-authored-by: Liang Wu <wuliang@google.com> COPYBARA_INTEGRATE_REVIEW=#3365 from UlookEE:fix_typo 1469de4 PiperOrigin-RevId: 827724001
Please ensure you have read the contribution guide before creating a pull request.
fix typo for several files.
Checklist
Additional context
Add any other context or screenshots about the feature request here.