Skip to content

Conversation

@UlookEE
Copy link
Contributor

@UlookEE UlookEE commented Nov 3, 2025

Please ensure you have read the contribution guide before creating a pull request.

fix typo for several files.

Checklist

  • I have read the CONTRIBUTING.md document.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have manually tested my changes end-to-end.
  • Any dependent changes have been merged and published in downstream modules.

Additional context

Add any other context or screenshots about the feature request here.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @UlookEE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the overall quality and readability of the codebase by addressing and correcting several typographical errors found in various Python files. These minor adjustments, primarily within docstrings and comments, ensure that the documentation and inline explanations are accurate and professional.

Highlights

  • Typo Corrections: Corrected various grammatical errors and misspellings across several Python files, primarily within docstrings and comments, to improve code readability and accuracy.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot adk-bot added the documentation [Component] This issue is related to documentation, it will be transferred to adk-docs label Nov 3, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes several typos and grammatical errors across various files, primarily in docstrings. The changes are correct and improve the clarity of the documentation. I've added a few suggestions to further improve code style by shortening some long lines in docstrings to adhere to PEP 8 recommendations, enhancing readability.

@wuliang229
Copy link
Collaborator

@UlookEE could you help add a line of "from future import annotations" to src/google/adk/sessions/state.py? https://github.com/google/adk-python/actions/runs/19044530131/job/54389399460?pr=3365

@ryanaiagent ryanaiagent self-assigned this Nov 3, 2025
@UlookEE
Copy link
Contributor Author

UlookEE commented Nov 4, 2025

@wuliang229 completed

copybara-service bot pushed a commit that referenced this pull request Nov 4, 2025
Merge #3365

**Please ensure you have read the [contribution guide](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) before creating a pull request.**

fix typo for several files.

### Checklist

- [x] I have read the [CONTRIBUTING.md](https://github.com/google/adk-python/blob/main/CONTRIBUTING.md) document.
- [x] I have performed a self-review of my own code.
- [ ] I have commented my code, particularly in hard-to-understand areas.
- [ ] I have added tests that prove my fix is effective or that my feature works.
- [x] New and existing unit tests pass locally with my changes.
- [x] I have manually tested my changes end-to-end.
- [x] Any dependent changes have been merged and published in downstream modules.

### Additional context

_Add any other context or screenshots about the feature request here._

Co-authored-by: Liang Wu <wuliang@google.com>
COPYBARA_INTEGRATE_REVIEW=#3365 from UlookEE:fix_typo 1469de4
PiperOrigin-RevId: 827724001
@adk-bot
Copy link
Collaborator

adk-bot commented Nov 4, 2025

Thank you @UlookEE for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit d2888a3.

Closing this PR as the changes are now in the main branch.

@adk-bot adk-bot closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation [Component] This issue is related to documentation, it will be transferred to adk-docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants