Skip to content

Conversation

@hanmingalbertyang
Copy link

Events without content, such as those from callbacks with state_deltas, do not represent a transfer to an agent that should continue the conversation.

Events without content, such as those from callbacks with state_deltas, do not represent a transfer to an agent that should continue the conversation.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hanmingalbertyang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the logic for identifying the last agent responsible for continuing a conversation. It addresses a potential issue where events without substantive content could lead to incorrect agent handoffs. By explicitly filtering out these content-less events, the system now more reliably determines which agent should resume interaction, ensuring a smoother and more accurate conversational flow.

Highlights

  • Event Filtering: Implemented a filter to skip events that do not contain content when determining the last transfer agent. This ensures that only meaningful conversational events are considered.
  • Agent Handoff Logic: Improved the accuracy of identifying the correct agent to resume a conversation by excluding non-conversational events, such as those originating from callbacks with state_deltas.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly filters out events without content when searching for the last agent to transfer to. By using a generator expression to iterate only over events where e.content is present, the change improves clarity and efficiency, ensuring that only relevant conversational events are considered. The logic is sound and aligns with the goal of ignoring state-only events during agent resumption.

@Jacksunwei Jacksunwei changed the title Skip events without content when finding the last transfer agent. chore: Skip events without content when finding the last transfer agent. Oct 27, 2025
@Jacksunwei Jacksunwei requested a review from DeanChensj October 28, 2025 01:30
@hanmingalbertyang
Copy link
Author

this was not the correct fix for the issue

@ryanaiagent ryanaiagent added the services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

services [Component] This issue is related to runtime services, e.g. sessions, memory, artifacts, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants