Skip to content

Conversation

@syangx39
Copy link

@syangx39 syangx39 commented Aug 28, 2025

close #2766

Who It's For

The --editable flag is primarily for developers who are modifying the core adk-python library code, not just for users who are building agents with the library.

Without the --editable Flag

1.	Make a code change in the adk-python library.
2.	Build a new version of the pip package.
3.	Publish the new package version to a repository like PyPI.
4.	Update your agent's deployment script to install that specific new version.
5.	Deploy the agent and test the change.

With the --editable Flag

1.	Make a code change in the adk-python library.
2.	Run adk deploy gke --editable ....

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @syangx39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the GKE deployment capabilities of the ADK CLI. It introduces options for developers to easily test local modifications to the ADK library by deploying an editable version, and provides greater control over the security context of deployed agents by allowing the specification of a Kubernetes Service Account. These additions streamline the development workflow and improve deployment flexibility.

Highlights

  • Editable ADK Installation for GKE: Users can now deploy ADK agents to GKE using a local, editable version of the ADK library, facilitating development and testing of ADK changes by copying the local source into the Docker image and installing it in editable mode.
  • Configurable Kubernetes Service Account: The GKE deployment command now supports specifying a Kubernetes Service Account, allowing for fine-grained control over the deployed agent's permissions within the cluster.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@adk-bot
Copy link
Collaborator

adk-bot commented Aug 28, 2025

Response from ADK Triaging Agent

Hello @syangx39, thank you for creating this PR!

To help reviewers evaluate your contribution, could you please address the following points from our contribution guidelines:

  • Associated Issue: All PRs, other than small documentation or typo fixes, should have an Issue associated. If one doesn't exist, could you please create one and link it here?
  • Testing Plan: Please include a testing plan section in your PR description to detail how you've tested these changes.

This information will help reviewers to review your PR more efficiently. Thanks!

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the GKE deployment CLI by adding support for editable installs of the ADK and allowing the specification of a Kubernetes service account. The changes are well-structured and include corresponding tests. My review identifies a high-severity bug in the Kubernetes YAML generation that could cause deployments to fail, along with a medium-severity maintainability issue in the new editable install logic. I've provided code suggestions to address these points.

@adk-bot adk-bot added bot triaged tools [Component] This issue is related to tools labels Aug 28, 2025
@adk-bot adk-bot requested a review from seanzhou1023 August 28, 2025 22:58
@hangfei
Copy link
Collaborator

hangfei commented Nov 6, 2025

close due to inactivity.

@hangfei hangfei closed this Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools [Component] This issue is related to tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] Support local source installation for adk deploy gke

5 participants