fix: change LlmResponse to use Content for transcriptions #2744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
copybara/799722909
branch
2 times, most recently
from
50eb6a1 to
c873c20
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
copybara/799722909
branch
7 times, most recently
from
aab61a6 to
6cb2a6a
Compare
The transcription change breaks the multi-agent transfer during live/bidi. Updates `GeminiLlmConnection` to populate the `content` field of `LlmResponse` with `types.Content` and `types.Part` objects for both input and output transcriptions, instead of using dedicated transcription fields. Also removes a debug print from `audio_cache_manager.py`. the transcription is not fully ready to be used yet so roll back the transcription change. PiperOrigin-RevId: 799851950
copybara-service
bot
force-pushed
the
copybara/799722909
branch
from
6cb2a6a to
3b997a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: change LlmResponse to use Content for transcriptions
The transcription change breaks the multi-agent transfer during live/bidi.
Updates
GeminiLlmConnectionto populate thecontentfield ofLlmResponsewithtypes.Contentandtypes.Partobjects for both input and output transcriptions, instead of using dedicated transcription fields. Also removes a debug print fromaudio_cache_manager.py.the transcription is not fully ready to be used yet so roll back the transcription change.