fix: add a2a endpoints

[dylan-apex]

Fixes #2624

Note: The routes object returned is very barebones and does not include a lot of important information that would make it useful in the Docs.

INFO:google_adk.google.adk.cli.fast_api:Route(path='/a2a/prime_agent', name='a2a_handler', methods=['POST'])
INFO:google_adk.google.adk.cli.fast_api:Route(path='/a2a/prime_agent/.well-known/agent.json', name='agent_card', methods=['GET', 'HEAD'])

In /docs endpoint

[gemini-code-assist]

Summary of Changes

Hello @dylan-apex, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #2624 by implementing the addition of A2A (Agent-to-Agent) API endpoints within the FastAPI application. It refactors the route registration process to use FastAPI's "add_api_route" method, allowing for better organization and explicit tagging of these new endpoints for improved API documentation and functionality.

Highlights

• FastAPI Route Registration: Refactored the method for adding new API routes to the FastAPI application, transitioning from direct list appending ("app.router.routes.append") to using "app.add_api_route()". This provides a more structured way to define routes, including specifying names, HTTP methods, and tags.
• A2A Endpoint Tagging: Ensured that all newly added A2A endpoints are explicitly tagged with "A2A Endpoints" when registered, improving API documentation and discoverability.
• Dependency Import: Added an import for "Response" from "starlette.responses", likely in preparation for handling specific HTTP responses for the new A2A endpoints.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly refactors the addition of A2A endpoints by using FastAPI's add_api_route method instead of directly manipulating the router's routes list. This is a good improvement as it utilizes the official API and adds useful tagging for documentation. I've pointed out one minor issue regarding an unused import that should be removed to improve code maintainability.

[adk-bot]

Response from ADK Triaging Agent

Hello @dylan-apex, thank you for creating this PR!

I noticed that the testing plan section and logs or screenshots are missing from the PR description. Could you please add these to help reviewers better understand and verify the fix?

You can find more details about our contribution requirements in our contribution guidelines.

Thanks!

[dylan-apex]

#2626 is a much better version of this. Deferring to that