feat: adding the ability to set Dockerfile base image for GKE and Cloud Run. #2597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ud Run deploys Defaults to the current hardcoded value of python:3.11-slim. Testplan: Added Unit tests for behavior with and without flag set. Also manually ran builds to ensure that you can successfully build adk on these environments with custom build images set. Fixes: #2219
Collaborator
|
@Jacksunwei Could you help review? |
Collaborator
|
Hi @tpryan this one has conflict now, could you help resolve? |
Collaborator
|
closing due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ud Run deploys
Defaults to the current hardcoded value of python:3.11-slim.
Testplan:
Added Unit tests for behavior with and without flag set. Also manually ran builds to ensure that you can successfully build adk on these environments with custom build images set.
Fixes: #2219