-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: dev ui url works in sub-apps #2568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@wyf7107 see how this PR is fixing the issues in the code, google/adk-web#218 |
|
That's the place |
|
@wyf7107 Hi, would you be so kind and review this PR? |
|
@wyf7107 could you take a look? |
|
Did you try to get a custom url to In theory we don't expect users to override the value in that file since adk web and the api server wil talk to each other in the same server. |
|
How can you programatically and reasonably get the value to the config you mentioned? It's part of a library, libraries are installed by package manager without reasonable way of modifying their contents. Yes, locally I tried to modify the contents when I was debugging it, but that's unusable for regular usage. |
Fixes google/adk-web#218.
Blocked by #2556, it depends on it because of the
base_url.Supersedes #2254 because that did not get requested for review and adk-bot was not triggered there for some reason.
I didn't figure out any better way to do this. Basically we need to have a way how to provide a custom URL to the assets/config/runtime-config.json. I have tested with my project that it works well.
The redirect to dev-ui needed some fixes too, so I added fixes and tests for that.
testing plan
I have added test that demonstrates the functionality in a sub-app.
I ran the relevant tests to my code and here are the results, everything passes.