Skip to content

Conversation

@emilmilow
Copy link

Fix #2323

@google-cla
Copy link

google-cla bot commented Aug 4, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@ravi-incred ravi-incred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when are we planning to merge this PR?

@SiyuanQi
Copy link

This doesn't appear to have been merged into the adk-python repository yet. Do you have any information on when it might be merged? Thanks!

span = trace.get_current_span()
# Special standard Open Telemetry GenaI attributes that indicate
# that this is a span related to a Generative AI system.
# For live events with usage metadata, create a new span for each event
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm what's the reasoning for creating a new span for every live event? just wondering if it would it cause too much overhead by generating too many spans

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of each back-and-forth communication with the live API was overriding the content of the last back-and-forth communication in the span.

@wukath
Copy link
Collaborator

wukath commented Nov 14, 2025

thanks for creating this PR! can you resolve the merge conflicts as well?

content=content, interrupted=message.server_content.interrupted
content=content,
interrupted=message.server_content.interrupted,
usage_metadata=self._fix_usage_metadata(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this cause duplicated usage metadata since we're adding it to all the LlmResponses? i.e. in the case that a message contains both content.parts and message.server_content.input_transcription

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check. When I created the PR, that was not the case, but perhaps it has changed since then.

@ryanaiagent ryanaiagent self-assigned this Dec 5, 2025
@ryanaiagent ryanaiagent added request clarification [Status] The maintainer need clarification or more information from the author tracing [Component] This issue is related to OpenTelemetry tracing labels Dec 5, 2025
@ryanaiagent
Copy link
Collaborator

Hi @emilmilow, Thank you for your contribution through this pull request! This PR has merge conflicts that require changes from your end. Could you please rebase your branch with the latest main branch to address these? Once this is complete, please let us know so we can proceed with the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

request clarification [Status] The maintainer need clarification or more information from the author tracing [Component] This issue is related to OpenTelemetry tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Live Mode is missing usage_metadata and telemetry tracing

6 participants