fix: Add support for required params #2212
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcadioli
approved these changes
Jul 28, 2025
filipecaixeta
approved these changes
Jul 28, 2025
Contributor
Author
|
bump - @hangfei - can we get some eyes into this PR? |
hcadioli
approved these changes
Aug 19, 2025
Collaborator
|
@thiagosalvatore Thanks for creating this PR? Could you please provide a test plan for this change? More details can be found in the contributing guide. |
Contributor
Author
|
@xuanyang15 sure, I can do this. Just note that this is live for over 2 weeks in our fork because it wasn't approved/reviewed until today. PR updated with the test run |
Collaborator
|
Thank you @thiagosalvatore! Could you please fix the formatting issue? You can use the |
Contributor
Author
fixed @xuanyang15 |
xuanyang15
approved these changes
Aug 20, 2025
xuanyang15
added
the
ready to pull
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
Merge #2212 This PR closes issue #2202 ADK was not parsing the required attribute when using LiteLLM, letting the LLM decide what is required vs not, not respecting function definitions. ## Test Plan There's a fork of adk-python that is being running live for over 2 weeks in our production environment with millions of requests per day. Below you can find a screenshot of the unit tests passing. I've also added one change to the test cases to cover this scenario <img width="1904" height="483" alt="image" src="https://github.com/user-attachments/assets/5a6eb069-63ae-45a3-baca-6b01543f56fb" /> COPYBARA_INTEGRATE_REVIEW=#2212 from thiagosalvatore:main 7de4037 PiperOrigin-RevId: 797393698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #2202
ADK was not parsing the required attribute when using LiteLLM, letting the LLM decide what is required vs not, not respecting function definitions.
Test Plan
There's a fork of adk-python that is being running live for over 2 weeks in our production environment with millions of requests per day.
Below you can find a screenshot of the unit tests passing. I've also added one change to the test cases to cover this scenario