fix: Add required parameters with defaults if missing

[jeffbryner]

fixes #2053

[seanzhou1023]

please update the commit message to follow https://www.conventionalcommits.org/en/v1.0.0/ and update the PR title to match it.

[codeninja]

We have noticed a serious issue with tool calling that may be related to this which is preventing us from updating from 1.6 -> 1.8.

When calling our tools with 1.8, ADK is sending undefined values for optional fields, rather than omitting them entirely from the request. This gets interpreted downstream by our GO API as an invalid value. Since Null != undefined and it's expecting the request to omit the values.

I suspect it may be related to this code.

Would it be possible to drop values entirely from the request which have undefined values?

[jeffbryner]

We have noticed a serious issue with tool calling that may be related to this which is preventing us from updating from 1.6 -> 1.8.
@codeninja I don't believe this code has been merged into 1.8 as the PR is still open.

[codeninja]

@jeffbryner I understand.

I believe our issue is introduced by line 379 in this code, above your diff, as it stands in 1.8. I found my way here while researching our issue.

I believe that the the API params are being polluted with undefined values which are making their way into the request.

[jeffbryner]

I believe our issue is introduced by line 379 in this code, above your diff, as it stands in 1.8. I found my way here while researching our issue.

I believe that the the API params are being polluted with undefined values which are making their way into the request.

Ah, I see. Probably best as a separate bug? This PR handles the case where the model doesn't send default parameters (probably assuming they are defaulted in the API) and explicitly sets defined, default values.

[jeffbryner]

Thanks!

[adk-bot]

Thank you @jeffbryner for your contribution! 🎉

Your changes have been successfully imported and merged via Copybara in commit 352dd99.

Closing this PR as the changes are now in the main branch.