Generate docs for the @adk/js package using TypeDoc#73
Closed
kalenkevich wants to merge 1 commit intomainfrom
Closed
Generate docs for the @adk/js package using TypeDoc#73kalenkevich wants to merge 1 commit intomainfrom
kalenkevich wants to merge 1 commit intomainfrom
Conversation
kalenkevich
commented
Jan 23, 2026
| import {maybeSetOtelProviders} from '../../src/telemetry/setup.js'; | ||
| import type {OTelHooks} from '../../src/telemetry/setup.js'; | ||
| import {trace} from '@opentelemetry/api'; | ||
| import {metrics} from '@opentelemetry/api'; |
Collaborator
Author
There was a problem hiding this comment.
those changes because of the formatter mismatch between google3 and vscode. I will resolve that a bit later, please ignore this for now.
Comment on lines
+126
to
+147
| const mockSpanProcessor = { | ||
| forceFlush: vi.fn(), | ||
| onStart: vi.fn(), | ||
| onEnd: vi.fn(), | ||
| shutdown: vi.fn(), | ||
| }; | ||
| const mockMetricReader = { | ||
| forceFlush: vi.fn(), | ||
| setMetricProducer: vi.fn(), | ||
| selectAggregation: vi.fn(), | ||
| selectAggregationTemporality: vi.fn(), | ||
| selectCardinalityLimit: vi.fn(), | ||
| collect: vi.fn(), | ||
| shutdown: vi.fn(), | ||
| } as unknown as any; | ||
| const mockLogProcessor = { | ||
| forceFlush: vi.fn(), | ||
| onStart: vi.fn(), | ||
| onEnd: vi.fn(), | ||
| shutdown: vi.fn(), | ||
| onEmit: vi.fn(), | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
this is actual change for this file. It is required to cast types properly else the doc generation will fail.
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import { toGeminiSchema } from "@google/adk/utils/gemini_schema_util"; |
Collaborator
Author
There was a problem hiding this comment.
same issue as above.
| }); | ||
| }); | ||
| import {Type} from '@google/genai'; | ||
| import {toGeminiSchema} from '../../src/utils/gemini_schema_util.js'; |
Collaborator
Author
There was a problem hiding this comment.
this is actual change. toGeminiSchema is a private and not exposed to the public so using relative path to test this.
happyhuman
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.