Support Swift6 version to Birthday sample app. #544
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
w-goog
left a comment
w-goog
left a comment
There was a problem hiding this comment.
Thank you for updating this! One small change requested, then we should be good to go :)
(Note: We'll explicitly support Swift 6 in the repo soon, at which point some of these changes may be reverted)
Samples/Swift/DaysUntilBirthday/Shared/Services/UserProfileImageLoader.swift
Outdated
Show resolved
Hide resolved
khetiSubrat
force-pushed
the
swit6birthdaysampleapp
branch
from
23afeb9 to
5446939
Compare
w-goog
left a comment
w-goog
left a comment
There was a problem hiding this comment.
Tested locally by pulling in these changes, and they look good. Thank you for making them! :)
|
Apologies for the delay, updating our Github actions to fix the tests :) This PR can be merged once #545 is complete. |
w-goog
force-pushed
the
swit6birthdaysampleapp
branch
from
5446939 to
4e59d85
Compare
2 participants
Support Swift6 version to Birthday sample app.