Assign to keychainStore asap in initializer #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camden-king
requested changes
Aug 1, 2025
Contributor
camden-king
left a comment
camden-king
left a comment
There was a problem hiding this comment.
We should consider if removing the user on sign out is desired before changing a behavior that has existed in GSI for 2+ years regardless of if it was introduced as a bug.
Samples/Swift/DaysUntilBirthday/DaysUntilBirthday.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
camden-king
reviewed
Aug 22, 2025
Samples/Swift/DaysUntilBirthday/DaysUntilBirthday.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
camden-king
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change assigns to the
_keychainStoreASAP uponGIDSignIninitialization. It also removes the logic in this initializer that checked for whether or not the app was previously installed and if so, subsequently removed older credentials from the keychain.