Update GIDAuthStateMigration to not perform migration when built for Mac Catalyst #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnnmrls
approved these changes
Jun 6, 2025
Member
|
Can you fix the typo in the title, please? |
Member
|
Spoke offline! Let's not perform any migrations on Mac Catalyst apps to avoid any increased risk of overwriting current signed in users. This means we'll have preprocessor directives such as
|
camden-king
changed the title
camden-king
merged commit 0b30eb6
into
camden-king/migration-bug-fixes
20 of 22 checks passed
camden-king
added a commit
that referenced
this pull request
Jun 17, 2025
camden-king
added a commit
that referenced
this pull request
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GIDAuthStateMigration we treat TARGET_OS_MACCATALYST as TARGET_OS_OSX however they should be treated the same as TARGET_OS_IOS apps. This PR updates that behavior for GIDAuthStateMigration but does not address other usage of TARGET_OS_MACCATALYST checks throughout the codebase.