Refactor theme validation to use catalog schema reference #621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
gspencergoog
approved these changes
Feb 12, 2026
Collaborator
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Oh, I see. Yes, this is probably an error in the spec, and was intended to work that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the A2UI v0.9 and v0.10 protocol schemas to strictly reference theme properties from the component catalog, aligning theme validation with the existing pattern for components and functions.
Changes:
Schema Refactoring:
themeobject fromstandard_catalog.json(v0.9 & v0.10).primaryColor,iconUrl, andagentDisplayNameinto the$defs/themedefinition withinstandard_catalog.json.server_to_client.json(v0.9 & v0.10) to reference the theme schema viacatalog.json#/$defs/themeinstead of using a generic object type.Documentation:
a2ui_protocol.md(v0.9 & v0.10) to explicitly state that the theme schema is part of the catalog and referenced via thecatalog.jsonalias.Testing:
theme_validation.jsontest suites for both versions to verify that valid themes are accepted and invalid ones (e.g., incorrect types or hex codes) are rejected.