Update contact lookup sample #559
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a significant and well-structured refactoring to create a centralized a2ui-agent package for managing A2UI schemas. The changes include a build-time hook to package schema files, a robust schema manager with fallback loading mechanisms, and a validator. The contact lookup sample has been updated to use this new package, which greatly improves maintainability and decouples the agent from hardcoded schemas. The overall approach is excellent. I've identified a few critical and high-severity issues related to exception handling and a NameError that could break the code at runtime, along with some medium-severity suggestions to improve the robustness of the build script and validation logic.
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
nan-yu
force-pushed
the
update-contact-lookup-sample
branch
4 times, most recently
from
6bc12ec to
6714d4f
Compare
nan-yu
force-pushed
the
update-contact-lookup-sample
branch
3 times, most recently
from
557fe78 to
7f8af23
Compare
- Add a base InferenceStrategy class - Add PackSpecsBuildHook to copy JSON schemas into the package during build time. - Update pyproject.toml to include assets and configure the build hook. - Implement A2uiSchemaManager for robust schema loading, pruning, and prompt generation.
nan-yu
force-pushed
the
update-contact-lookup-sample
branch
from
7f8af23 to
187797d
Compare
Tested: - [x] The contact_lookup client successfully connected to the contact_lookup agent and rendered the response correctly.
nan-yu
force-pushed
the
update-contact-lookup-sample
branch
from
187797d to
91121f2
Compare
1 participant
Tested:
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.