feat: Add a A2uiValidator to validate loaded examples #557
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces schema bundling and validation capabilities, which is a significant feature enhancement. The changes include a new build hook for packaging schema files, a robust A2uiSchemaManager for handling schema loading and bundling, and an A2uiValidator class. The addition of comprehensive unit and integration tests is commendable and ensures the reliability of the new functionality. I've identified a critical issue related to a missing import that would lead to a runtime error, a high-severity issue concerning error silencing that could complicate debugging, and a couple of medium-severity suggestions for code cleanup and correctness. Overall, this is a well-structured contribution.
a2a_agents/python/a2ui_agent/src/a2ui/inference/template/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/loader.py
Outdated
Show resolved
Hide resolved
a2a_agents/python/a2ui_agent/src/a2ui/inference/schema/manager.py
Outdated
Show resolved
Hide resolved
nan-yu
force-pushed
the
a2ui-validator
branch
5 times, most recently
from
283be8d to
c42f84f
Compare
nan-yu
force-pushed
the
a2ui-validator
branch
2 times, most recently
from
7464284 to
8f7adb5
Compare
nan-yu
changed the title
nan-yu
force-pushed
the
a2ui-validator
branch
from
8f7adb5 to
00db217
Compare
- Add a base InferenceStrategy class - Add PackSpecsBuildHook to copy JSON schemas into the package during build time. - Update pyproject.toml to include assets and configure the build hook. - Implement A2uiSchemaManager for robust schema loading, pruning, and prompt generation.
nan-yu
force-pushed
the
a2ui-validator
branch
from
00db217 to
86ea5d0
Compare
nan-yu
force-pushed
the
a2ui-validator
branch
from
86ea5d0 to
836b285
Compare
|
/genui summary |
2 participants
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.