-
Notifications
You must be signed in to change notification settings - Fork 514
docs for public #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs for public #277
Conversation
port from multiple internals sources into an initial structure of documentation
simplifying some overly verbose pages, organizing content from blog to docs
docs/quickstart.md
Outdated
| ## Step 3: Navigate to the Angular Client | ||
|
|
||
| ```bash | ||
| cd samples/client/angular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would recommend having the lit client here..it has more styling options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked in a script for lit similar to angular..installs deps, runs agents and starts shell app that runs both agents:
cd samples/client/lit
npm run demo:all
Restaurant app at: http://localhost:5173/
Contacts app at: http://localhost:5173/?app=contacts
dmandar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's land this and iterate as required.
jacobsimionato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is great overall, but there are many incorrect example snippets. I started trying to suggest fixes for them all, but I think the more efficient way is to describe then here, and then you can get Gemini to fix them for you, or we can in a follow up PR.
I think a lot of the confusion here comes from v0.8 vs v0.9. We should write all the docs for v0.8 right now, because that's what all the renderers and agent samples use, so it's the only way we can give people a cohesive story.
v0.9 is purely a spec proposal at this point!
Make sure all snippets match v0.8 schema as shown in specifications/v0.8.
Some specific issues:
- When referring to "children" use "explicitList" or "template" attributes.
- When using literal leaf values, use typed names e.g. "literalString" rather than just "literal".
- There is no createSurface message in v0.8
Make sure code snippets match APIs from actual renderers
It seems like there are some APIs here which don't exist? E.g A2uiRenderer etc?
Co-authored-by: jacobsimionato <jsimionato@google.com>
Co-authored-by: jacobsimionato <jsimionato@google.com>
jacobsimionato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey this is great overall, but there are many incorrect example snippets. I started trying to suggest fixes for them all, but I think the more efficient way is to describe then here, and then you can get Gemini to fix them for you, or we can in a follow up PR.
I think a lot of the confusion here comes from v0.8 vs v0.9. We should write all the docs for v0.8 right now, because that's what all the renderers and agent samples use, so it's the only way we can give people a cohesive story.
v0.9 is purely a spec proposal at this point!
Make sure all snippets match v0.8 schema as shown in specifications/v0.8.
Some specific issues:
- When referring to "children" use "explicitList" or "template" attributes.
- When using literal leaf values, use typed names e.g. "literalString" rather than just "literal".
- There is no createSurface message in v0.8
Make sure code snippets match APIs from actual renderers
It seems like there are some APIs here which don't exist? E.g A2uiRenderer etc?
Co-authored-by: jacobsimionato <jsimionato@google.com>
Co-authored-by: jacobsimionato <jsimionato@google.com>
jacobsimionato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more comments for the rest of the files
docs/roadmap.md
Outdated
| Key features: | ||
|
|
||
| - ✅ Streaming JSONL message format | ||
| - ✅ Four core message types (`createSurface`, `updateComponents`, `updateDataModel`, `deleteSurface`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This are from v0.9 - in v0.8 it's surfaceUpdate, dataModelUpdate, beginRendering and deleteSurface
I defer to people with more experience with these kinds of launches, but I'm a bit worried that it'll be too much work to make these docs accurate in 24 hours. I think it might make sense to try to commit a smaller number of accurate docs, so as we build up more, our agents don't get confused by misinformation. I was wondering about an approach like:
But alternatively, if you want to do a pass and submit I'm fine with that and then tomorrow we can all swarm on updating them one-by-one. If we do that strategy, let's meet up tomorrow so we can divide and conquer. |
|
Okay, I made a heap of changes and pushed them to the branch - PTAL! |
Co-authored-by: jacobsimionato <jsimionato@google.com>
multiple passes of crossreferencing and reducing total lines in docs
Co-authored-by: jacobsimionato <jsimionato@google.com>
Reduce guide documentation by removing AI-generated code that hasn't been verified against actual samples. Replace with high-level concepts, TODOs for future verified content, and links to working sample code.
* update disclaimers * minor update
gspencergoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just partway through review, but here are some comments.
docs/guides/client-setup.md
Outdated
|
|
||
| | Renderer | Platform | Status | | ||
| |----------|----------|--------| | ||
| | **Lit (Web Components)** | Web | ✅ Stable | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Stable" is all relative in an "Experimental" repo, but I guess that's implied.
jacobsimionato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is close enough as a starting point :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look great on a dark mode background, but I suppose there's nothing to do about that. I don't think there's any way to select the image based on brightness mode.
multiple docs changes.
To try this locally: