fix(react): convert GooglePayButton to functional component for React 19 compatibility#393
Open
hanumanteshvar07-design wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
… 19 compatibility
edb667c to
893c580
Compare
824fbda to
893c580
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the compatibility issue with React 19 where accessing .ref on a React element was deprecated and now throws a warning/error.
By converting GooglePayButton to a functional component using React.forwardRef, we align with modern React patterns and ensure that ref is handled correctly as a prop, avoiding the legacy class-component behavior that triggers React 19 warnings.
Changes:
src/button-react/GooglePayButton.tsx: Converted to a functional component with React.forwardRef.
src/button-react/GooglePayButton.test.tsx: Updated to support both legacy ReactDOM.render and the modern createRoot API.
src/button-react/GooglePayButton.react19.test.tsx: Enhanced to include regression tests for React 19 ref access patterns.
Formatting: Normalized codebase formatting using Prettier to satisfy linting rules.
Verification:
All 49 tests passed (including core logic, web component, and React components).
Verified compatibility with both React 16 and React 19 environments.
npm run lint passes successfully.