Skip to content

Remove beta warning and obsolete flag conversion for Cloud Run jobs #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
178inaba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove beta warning and obsolete flag conversion for Cloud Run jobs #594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/main/index.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 0 additions & 16 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,6 @@ export async function run(): Promise<void> {
throw new Error(`Unkown metadata type "${kind}", expected "Job" or "Service"`);
}
} else if (job) {
logWarning(
`Support for Cloud Run jobs in this GitHub Action is in beta and is ` +
`not covered by the semver backwards compatibility guarantee.`,
);

deployCmd = ['run', 'jobs', 'deploy', job];

if (image) {
Expand All @@ -189,17 +184,6 @@ export async function run(): Promise<void> {
deployCmd.push('--wait');
}

// There is no --update-secrets flag on jobs, but there will be in the
// future. At that point, we can remove this.
const idx = deployCmd.indexOf('--update-secrets');
if (idx >= 0) {
logWarning(
`Cloud Run does not allow updating secrets on jobs, ignoring ` +
`"secrets_update_strategy" value of "merge"`,
);
deployCmd[idx] = '--set-secrets';
}

// Compile the labels
const defLabels = skipDefaultLabels ? {} : defaultLabels();
const compiledLabels = Object.assign({}, defLabels, labels);
Expand Down