feat(cli): add full-access approval controls#27026
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the CLI's privileged approval controls by introducing a formal '--full-access' flag. It improves the user experience by deprecating the informal 'YOLO' terminology in favor of clearer language, while maintaining backward compatibility for existing scripts. Additionally, it enhances security by defaulting to sandbox mode when these privileged modes are active. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request rebrands "YOLO mode" to "Full Access mode" across the CLI, documentation, and UI. It introduces a new --full-access flag, deprecates the --yolo flag (treating it as an alias), and adds support for full_access and full-access values in the --approval-mode option. Additionally, the changes include logic to automatically enable the sandbox when a privileged approval mode is active and improve error reporting when multiple conflicting approval flags are provided. I have no feedback to provide.
b91ae74 to
a1e66ed
Compare
|
Rebased this PR onto current Root cause: the privileged approval mode is still exposed primarily through Approach: add Validation after rebase:
I kept the issue reference as |
Summary
Validation
Related Issues
Related to #21432