Skip to content

fix(test): move flaky ctrl-c-exit test to non-blocking suite#23732

Merged
mattKorwel merged 1 commit intomainfrom
mk-flaky-2
Mar 25, 2026
Merged

fix(test): move flaky ctrl-c-exit test to non-blocking suite#23732
mattKorwel merged 1 commit intomainfrom
mk-flaky-2

Conversation

@mattKorwel
Copy link
Collaborator

Following the pattern in #23259, this PR moves the flaky ctrl-c-exit.test.ts to the non-blocking suite by using the skipFlaky helper. This test has been intermittently failing in CI and blocking PRs.

@mattKorwel mattKorwel requested a review from a team as a code owner March 25, 2026 00:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses continuous integration instability by reclassifying a known flaky test. By applying a conditional skip, the problematic ctrl-c-exit.test.ts is prevented from blocking PRs, ensuring a smoother development workflow without removing the test entirely.

Highlights

  • Flaky Test Handling: The ctrl-c-exit.test.ts integration test, which has been intermittently failing in CI, has been moved to a non-blocking test suite.
  • CI Stability Improvement: This change aims to prevent the flaky test from blocking pull requests and improve overall CI stability by utilizing the skipFlaky helper.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the integration-tests/ctrl-c-exit.test.ts file. It imports skipFlaky from test-helper.js and uses it to conditionally skip the 'Ctrl+C exit' test suite, likely to address flakiness. There is no feedback to provide.

@github-actions
Copy link

Size Change: -4 B (0%)

Total Size: 26.3 MB

Filename Size Change
./bundle/chunk-23DI7L5V.js 0 B -3.4 kB (removed) 🏆
./bundle/chunk-RGAW74XF.js 0 B -14.6 MB (removed) 🏆
./bundle/chunk-XN6LIP7Z.js 0 B -3.64 MB (removed) 🏆
./bundle/core-V2XIMZSL.js 0 B -43.4 kB (removed) 🏆
./bundle/devtoolsService-UUX2LQ3U.js 0 B -27.7 kB (removed) 🏆
./bundle/gemini-O3YTTRVA.js 0 B -521 kB (removed) 🏆
./bundle/interactiveCli-R244XGXP.js 0 B -1.62 MB (removed) 🏆
./bundle/oauth2-provider-PTOK7KZE.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-HQOL3JL2.js 3.64 MB +3.64 MB (new file) 🆕
./bundle/chunk-R5SSR7G4.js 3.4 kB +3.4 kB (new file) 🆕
./bundle/chunk-XMWEHVQM.js 14.6 MB +14.6 MB (new file) 🆕
./bundle/core-4DUPLGVS.js 43.4 kB +43.4 kB (new file) 🆕
./bundle/devtoolsService-NJUGZNH5.js 27.7 kB +27.7 kB (new file) 🆕
./bundle/gemini-3EJ4JOGG.js 521 kB +521 kB (new file) 🆕
./bundle/interactiveCli-7QWKWMK4.js 1.62 MB +1.62 MB (new file) 🆕
./bundle/oauth2-provider-R7D7MLPJ.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size Change
./bundle/chunk-34MYV7JD.js 2.45 kB 0 B
./bundle/chunk-5AUYMPVF.js 858 B 0 B
./bundle/chunk-664ZODQF.js 124 kB 0 B
./bundle/chunk-DAHVX5MI.js 206 kB 0 B
./bundle/chunk-IUUIT4SU.js 56.5 kB 0 B
./bundle/chunk-IV2KUFMZ.js 1.96 MB 0 B
./bundle/chunk-RJTRUG2J.js 39.8 kB 0 B
./bundle/cleanup-R4BVQ3OU.js 0 B -856 B (removed) 🏆
./bundle/devtools-36NN55EP.js 696 kB 0 B
./bundle/dist-T73EYRDX.js 356 B 0 B
./bundle/gemini.js 2.06 kB 0 B
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB 0 B
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB 0 B
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB 0 B
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB 0 B
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB 0 B
./bundle/memoryDiscovery-CXSTQXLK.js 922 B 0 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B
./bundle/src-QVCVGIUX.js 47 kB 0 B
./bundle/tree-sitter-7U6MW5PS.js 274 kB 0 B
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB 0 B
./bundle/cleanup-2JA4X4NG.js 856 B +856 B (new file) 🆕

compressed-size-action

@mattKorwel mattKorwel enabled auto-merge March 25, 2026 00:13
@mattKorwel mattKorwel added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit 0552464 Mar 25, 2026
30 checks passed
@mattKorwel mattKorwel deleted the mk-flaky-2 branch March 25, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants