fix(test): move flaky ctrl-c-exit test to non-blocking suite#23732
fix(test): move flaky ctrl-c-exit test to non-blocking suite#23732mattKorwel merged 1 commit intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses continuous integration instability by reclassifying a known flaky test. By applying a conditional skip, the problematic Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request modifies the integration-tests/ctrl-c-exit.test.ts file. It imports skipFlaky from test-helper.js and uses it to conditionally skip the 'Ctrl+C exit' test suite, likely to address flakiness. There is no feedback to provide.
|
Size Change: -4 B (0%) Total Size: 26.3 MB
ℹ️ View Unchanged
|
Following the pattern in #23259, this PR moves the flaky
ctrl-c-exit.test.tsto the non-blocking suite by using theskipFlakyhelper. This test has been intermittently failing in CI and blocking PRs.