Add recurring /loop command with auto-removal#23714
Add recurring /loop command with auto-removal#23714cruzlauroiii wants to merge 4 commits intogoogle-gemini:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Gemini CLI's interactive capabilities by introducing a new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
962db6b to
5898d65
Compare
There was a problem hiding this comment.
Code Review
This pull request introduces a new /loop command, allowing users to schedule recurring messages to the LLM at specified intervals. The implementation includes UI state management for scheduling, modifications to the Gemini stream processing to handle a special loop stop marker, and new utility functions for command argument parsing and submission text generation. Feedback indicates a potential Denial of Service vulnerability if large interval values are not properly validated for setInterval, and a style guide violation regarding the copyright year in license headers, which should be updated from 2026 to 2024.
e850c29 to
5ba6a92
Compare
|
Rebased this branch onto the latest This branch addresses the outstanding Gemini Code Assist review feedback:
Validation rerun on the rebased branch:
Checks are currently green, and the branch now contains the current upstream |
5ba6a92 to
19321a0
Compare
19321a0 to
153a023
Compare
Summary
/loop <Xm> <message>command for interactive recurring promptsValidation
npm run typecheck --workspace @google/gemini-clinpm test --workspace @google/gemini-cli -- src/ui/utils/loopCommand.test.ts src/ui/commands/loopCommand.test.ts src/ui/hooks/slashCommandProcessor.test.tsx src/ui/hooks/useGeminiStream.test.tsx src/ui/AppContainer.test.tsxnpm run build --workspace @google/gemini-cliFixes #23713
Related duplicate request: #22653