Fix: Handle empty prompt arrays in make_seq2seq_fields (#483) #488
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #483. This PR fixes a crash in make_seq2seq_fields when an empty prompt array is provided. The previous logic attempted to create a target mask with negative dimensions (len(prompt) - 1) when prompt was empty. The fix adds conditional logic to generate a correct mask (based on response length) if the prompt is empty.