docs(spec): fix three doubled-article typos in AP2 specification#260
Open
Ectsang wants to merge 2 commits into
Open
docs(spec): fix three doubled-article typos in AP2 specification#260Ectsang wants to merge 2 commits into
Ectsang wants to merge 2 commits into
Conversation
Three occurrences of repeated article in the AP2 specification document: - Line 126: "The The Merchant MUST provide..." -> "The Merchant MUST provide..." - Line 200: "the the Shopping Agent receives..." -> "the Shopping Agent receives..." - Line 204: "The The Merchant verifies..." -> "The Merchant verifies..." Pure typo fix. No semantic changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects several grammatical errors in the documentation by removing duplicate words such as "The The" and "the the". The review feedback identifies an additional opportunity to improve consistency by lowercasing the word "verification" in one of the modified sections.
| Upon receiving the Checkout and Payment Mandate, the Shopping Agent forwards the | ||
| Payment Mandate to the Credential Provider (and possibly the Network) for | ||
| Verification. Upon successful verification, the the Shopping Agent receives a | ||
| Verification. Upon successful verification, the Shopping Agent receives a |
Contributor
There was a problem hiding this comment.
The word "Verification" at the beginning of this line (which concludes the sentence starting on the previous line) is capitalized, while the subsequent sentence uses "verification" in lowercase. For consistency with the rest of the document and the immediate context, it should be lowercase.
Suggested change
| Verification. Upon successful verification, the Shopping Agent receives a | |
| verification. Upon successful verification, the Shopping Agent receives a |
The word 'Verification' at line 200 starts a new line but continues
the prior sentence ("...for verification."). Capitalization was a
line-wrap artifact, not a sentence start. Lowercased for consistency
with the rest of the document and the following sentence which uses
lowercase 'verification'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three occurrences of a repeated article ("The The" / "the the") in
docs/ap2/specification.md:Pure typo fix. No semantic changes.
Changes
docs/ap2/specification.md— 3 lines, 3 doubled-article corrections.